Repository navigation
Conversation
|
Tested on top of master (72bf89c), Windows. First with a script and NPCs only, then in game (0.3.7-R5) with the values on a textdraw while the NPC walked, sprinted and drove around next to me. On master NPC_GetVelocity just hands back the position (1495.0, 1395.0, 10.8 for an idle NPC standing there, and it keeps following the position while it moves). With this PR:
One thing I noticed while driving with NPC_Move: NPC_GetVelocity gives 0.00999 but GetVehicleVelocity on the car gives 0.19999, because sendDriverSync multiplies it by 20 and the getter doesn't. Not sure if that's meant to stay that way, but a script reading an NPC's speed in a car gets a number 20x smaller than the vehicle's. Probably fine as a follow-up, the fix itself LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NPC::getVelocity returned the player's position, so NPC_GetVelocity gave back the NPC's coordinates instead of its velocity. It now returns velocity_, the value setVelocity writes and the syncs send. Only reads of an NPC's velocity are affected